PgSQL dsn improvements #439
Conversation
modified: database/database.go modified: example/homer5_config/heplify-server.toml modified: example/homer7_config/heplify-server.toml
|
|
|
Hi I am happy to see find a PR for this as we really need it. Do we have a lead time on when this might be merged? Not having sslmode means we cannot use homer. Thanks |
|
DBPort is a breaking change so can't merge. |
Can you please point what exactly is not right ? |
|
In the old config you use DBAddr as "localhost:1234" |
|
Yes, DBPort is part of pull request, I added corresponding options to config.go. |
|
There are alot of users who have config files with DBAddr set to for example "localhost:1234". |
|
Fully agree with @negbie there's no reason to break backwards compatibility for such a minimal change with no particular advantage. @volga629-1 could you merge those back or make the second an optional parameter to retain compatibility? |
|
Hello, I created a pull request that allows SSL Mode for the DB Connection without breaking backward compatibility. #449 |
|
Guys, you should read more carefully, this PR should not be approved but ZionDials PR #449 |
|
@negbie oki! thanks for pointing :) |
|
#449 was merged so closing this. Thanks @volga629-1 for bringing this up. |
Ticket reference: #437