Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Use new shape in one more spot #3321

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[python] Use new shape in one more spot #3321

merged 2 commits into from
Nov 13, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Found a spot in one-off/ad-hoc testing in my laptop on a particular old dataset.

Notes for Reviewer:

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (3d83782) to head (230bdd9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
+ Coverage   85.19%   85.20%   +0.01%     
==========================================
  Files          53       53              
  Lines        5565     5577      +12     
==========================================
+ Hits         4741     4752      +11     
- Misses        824      825       +1     
Flag Coverage Δ
python 85.20% <28.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.20% <28.57%> (+0.01%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit d0cbd2d into main Nov 13, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/more-use-shape branch November 13, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants