-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Fix a compiler warning #3310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
==========================================
+ Coverage 85.37% 85.50% +0.12%
==========================================
Files 52 52
Lines 5499 5506 +7
==========================================
+ Hits 4695 4708 +13
+ Misses 804 798 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -153,7 +153,7 @@ std::unique_ptr<ArrowSchema> create_index_cols_info_schema( | |||
|
|||
auto schema = ArrowAdapter::make_arrow_schema(names, tiledb_datatypes); | |||
|
|||
for (size_t i = 0; i < schema->n_children; ++i) { | |||
for (size_t i = 0; i < (size_t)schema->n_children; ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mean to nitpick, but:
- do we encourage use of C-style (legacy) casts, vs say a
static_cast<>
? - if
schema->n_children
is signed, alternative might just be to makei
signed?
either works for me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bkmartinjr !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, but left comments on possible improvement
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Changes:
Fix a compiler warning:
Notes for Reviewer: