Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/r] Move beyond the new-shape feature flag #3301

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 6, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

These have been on by default for several weeks now. It's time to keep them.

Note there is another bit of logic (same files) around whether dense arrays can have current domain, which can't be removed until core 2.27 is released, and we move our core dependency to 2.27.

Notes for Reviewer:

This is less ambitious than #3259, which needs to wait until core 2.27.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.48%. Comparing base (33b104c) to head (2c284cd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3301      +/-   ##
==========================================
+ Coverage   85.29%   85.48%   +0.18%     
==========================================
  Files          52       52              
  Lines        5517     5499      -18     
==========================================
- Hits         4706     4701       -5     
+ Misses        811      798      -13     
Flag Coverage Δ
python 85.48% <89.47%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.48% <89.47%> (+0.18%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [python/r] Move beyond new-shape feature flag [python/r] Move beyond the new-shape feature flag Nov 6, 2024
@johnkerl johnkerl marked this pull request as ready for review November 6, 2024 23:01
@johnkerl johnkerl merged commit 4a2cbcb into main Nov 7, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/ffena branch November 7, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants