Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Include tiledbsoma_upgrade_shape for DenseNDArray #3288

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 3, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

This was an omission on the 2.27 work.

Notes for Reviewer:

PR stacking as of today:

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (5f154bf) to head (86752ec).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3288      +/-   ##
==========================================
- Coverage   83.67%   83.61%   -0.07%     
==========================================
  Files          51       51              
  Lines        5556     5571      +15     
==========================================
+ Hits         4649     4658       +9     
- Misses        907      913       +6     
Flag Coverage Δ
python 83.61% <25.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.61% <25.00%> (-0.07%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 9a45dda into main Nov 4, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/dense-ugrsh branch November 4, 2024 18:43
@johnkerl
Copy link
Member Author

johnkerl commented Nov 4, 2024

Thanks @jp-dark !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants