Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Centralize sparse/dense pybind11 shape methods #3261

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 30, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

This is a split-out to simplify #3244 which turns out to be multi-faceted

Notes for Reviewer:

No new unit tests -- proof of success here is that all existing unit-test cases contiunue to pass.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.91%. Comparing base (467af01) to head (88ee4e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3261      +/-   ##
==========================================
+ Coverage   83.79%   83.91%   +0.11%     
==========================================
  Files          51       51              
  Lines        5560     5563       +3     
==========================================
+ Hits         4659     4668       +9     
+ Misses        901      895       -6     
Flag Coverage Δ
python 83.91% <75.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.91% <75.00%> (+0.11%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnkerl johnkerl merged commit 7a9c67e into main Oct 30, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/pybind11-nda-sizing branch October 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants