[c++] Improve exception-handling for query futures #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2789 +/- ##
==========================================
+ Coverage 89.87% 90.02% +0.15%
==========================================
Files 37 37
Lines 3940 3940
==========================================
+ Hits 3541 3547 +6
+ Misses 399 393 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
* [c++] Improve exception-handling for query futures * why did this break now
johnkerl
added a commit
that referenced
this pull request
Jul 11, 2024
* [c++] Improve exception-handling for query futures * why did this break now Co-authored-by: John Kerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Split out from PR #2785 for issue #2407. This change is makes a unit-test case pass on that PR. For this PR, it's sufficient to observe that existing unit tests all still pass.