Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile picture feture with moderncv theme #174

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

kito323
Copy link
Contributor

@kito323 kito323 commented Sep 17, 2024

Only for this theme and only optional "add" possibility. Should also include design parameters (height and frame thickness) but didn't know how to add those so that they would have default values.
Also updated user guide FAQ about it.

Only for this theme and only optional "add" possibility. Should also include design parameters (height and frame thickness) but didn't know how to add those so that they would have default values.
@kito323
Copy link
Contributor Author

kito323 commented Sep 17, 2024

Hope this is how it was intended to be updated. Maybe add design parameters for the image too. Currently "hard coded" with height of 3.5cm and no frame. Let me know if it works as intended.

@kito323
Copy link
Contributor Author

kito323 commented Sep 17, 2024

Okay I can already see that it fails on ubuntu and macos tests and I know why. Because the path for the image uses different dir delimiters and there are libraries that take care of that but how would that be done in the Preamble.j2.tex file or are there any good examples in the codebase that I could follow?

@sinaatalay
Copy link
Owner

Thank you! Sorry for the late response.

I think we shouldn't add this feature to RenderCV itself (built-in Preamble.j2.tex), as it won't be available for all the themes. Instead, we should write a step-by-step guide in the FAQ that explains how to add profile pictures to any theme. It should basically say: include a path to a photo in the YAML file and update your Preamble.j2.tex accordingly (but more detailed, ofc).

@kito323
Copy link
Contributor Author

kito323 commented Oct 3, 2024

Reverted the previous commit and only updated FAQ with the instructions of the simplest implementation. If there are too many details, feel free to adjust it.

@kito323
Copy link
Contributor Author

kito323 commented Oct 3, 2024

Maybe also linking the two issues to this PR as partial solution or something (Ability to add a profile photo #28 and Answer an FAQ: Can I add a profile picture? #74). Not sure if I have permissions to do that...

@sinaatalay
Copy link
Owner

Thank you.

@sinaatalay sinaatalay merged commit 377aa9f into sinaatalay:main Oct 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants