Rework the WorkDir and Persistance in ShellExecutioner #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking the ShellExecutioner to make it possible to persist the data that triggered an execution. This can be helpful when troubleshooting a shell command.
I also discovered a bug where multiple executions would result in failures due to the workdir not existing. The ShellExecutioner was creating the directory when
Newwas called, and it was removing it inExecute(without recreating). There is really no need to create the directory inside ofNewso I moved the creation and cleanup intoExecuteinstead.Tests have been added for the bug and also the new functionality
PersistData.