Assign generated signals a unique name #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving a session setup, the trace view refers to signals using their internal_name(). Without this change, internal_name() would return an empty string for all generated signals. This leads to name collisions in the session settings file.
|
Let me know if you prefer some other mechanism like numbering all generated signals just before a session setup is saved. FYI: I'm also working on a feature to save/restore a complete trace tree including signal groups and vertical positions. This will also depend on some kind of unique identifier for all signals. |
The mingw cross compilation script in sigrok-utils freezes Qt at version 5.7 for Windows XP support. Qt5.7 does not support QUuid::WithoutBraces. Rationale for removing the braces: They are encoded using an escape sequence in the settings file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a session setup, the trace view refers to signals using their internal_name().
Without this change, internal_name() would return an empty string for all generated signals.
This leads to name collisions in the session settings file.