avr_isp: add read calibration byte decoder. Add poll RDY/nBSY flag decoder. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenugrec
reviewed
Mar 4, 2024
decoders/avr_isp/pd.py
Outdated
| @@ -223,6 +242,10 @@ def handle_command(self, cmd, ret): | |||
| self.handle_cmd_read_fuse_high_bits(cmd, ret) | |||
| elif cmd[:3] == [0x50, 0x08, 0x00]: | |||
| self.handle_cmd_read_extended_fuse_bits(cmd, ret) | |||
| elif cmd[:3] == [0x38, 0x00, 0x00]: | |||
There was a problem hiding this comment.
I'm not sure I understand how this set of if/elif is sorted (by... alphabetical function name ?) but it doesn't look like your additions quite fit where they should
There was a problem hiding this comment.
Added a commit that sorts the 'elif cmd[:3]' based on the 3-byte value.
|
as stated in IRC, needs corresponding PR in tests |
Give me some time and I will try to figure out how to make a test. |
atoomnetmarc
added a commit
to atoomnetmarc/sigrok-dumps
that referenced
this pull request
Mar 5, 2024
atoomnetmarc
added a commit
to atoomnetmarc/sigrok-test
that referenced
this pull request
Mar 5, 2024
Well, I think I got a test running with a new dump. How did I do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I added decoding of the calibration byte read and the polling of the RDY/nBSY flag to the avr_isp decoder.