-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'capture_tags' field to captures metadata #146
base: main
Are you sure you want to change the base?
Conversation
d05a436
to
7c15a04
Compare
@jacobagilbert - Agreed on the simplicity of the change, but I'm not sure I'm sold on the concept, yet. Can you give me an example of how you use this field, and how it's different from an annotation's description field that is describing a chunk of samples in the same segment? |
The primary reason for my making the PR to add this field is to contain capture-segment-scoped information about the recording. Examples:
This might be better handled by application (extension) specific fields, if you think thats the case then I can withdraw this. |
So I am changing my mind on this slightly. I actually think what is needed is a short form field for machine parsing, be that: Not sure where your current thoughts on this @bhilburn... Specifically I am writing a |
7c15a04
to
5e249ee
Compare
@bhilburn @Teque5 dusting this off because i think its useful. the updates here are basically the "most complicated" way of doing this. I think i could get 99% of the utility i need out of this with a single string for the Same motivation as before, to help automated processing (specifically monte-carlo sampling from datasets) do so most effectively, and to enable users to specify problems in datasets without actually modifying the data files and resorting to clunky things like removing parts of files. Let me know what you think. |
I like the idea of adding tags. A few thoughts:
|
Thanks for looking at this. |
5e249ee
to
f625d10
Compare
f625d10
to
9e28fe2
Compare
@Teque5 updated per your feedback and i explicitly included some info on overlap with annotations. I am still unsure if this should be a single tag (much simpler, probably will handle most cases) or a list... Open to input here. |
Another use case that I came across just recently was to annotate a Bluetooth recording where the acquisition and sync phase between two BT devices is explicitly identified followed by a segment identifying active data transfer phase. |
This is something discussed in #124 that I continue to find need of; there is currently no way to track why a segment exists that information is sufficiently captured via
frequency
ordatetime
.