Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide native assets in asset selection modals for limit orders #8121

Open
wants to merge 6 commits into
base: limit-orders-redux
Choose a base branch
from

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Nov 13, 2024

Description

Hides native assets in asset selection for limit orders, as native assets are not supported.

Fixes 2 production bugs:

  • [phantom wallet only] Solana should not be shown in chain drop-down menus, but in prod it appears.
  • Chains for the "buy" asset which not supported by the wallet should appear in the chain drop-down on the right, but in prod they are disabled.

Issue (if applicable)

closes #6203

Risk

High Risk PRs Require 2 approvals

Moderate risk as this makes some minor refactors of the trade asset selection components.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Thoroughly test asset selection, focusing on trade input and less so on limit orders - trades are user facing and limit orders are behind a feature flag.

Spot Trade

  • Native assets should still be allowed
  • [phantom wallet] Solana should not appear in the list of assets or chains (prod shows it in the chain drop-down on the right which is a bug)
  • Chains for the "buy" asset which not supported by the wallet should appear in the chain drop-down on the right (prod disables them which is a bug), and should prompt for a manual receive address

Limit order

  • Native assets should be hidden
  • [phantom wallet] Solana should not appear in the list of assets or chains
  • Chains for the "buy" asset which not supported by the wallet should appear in the chain drop-down on the right, and should prompt for a manual receive address

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Native assets hidden for limit order asset selection:

[phantom wallet] Solana should not appear in the list of assets or chains
Prod:

This PR:

Chains for the "buy" asset which not supported by the wallet should appear in the chain drop-down on the right.
Prod:

This PR:

@woodenfurniture woodenfurniture changed the base branch from develop to limit-orders-redux November 13, 2024 22:08
@woodenfurniture woodenfurniture marked this pull request as ready for review November 13, 2024 23:58
@woodenfurniture woodenfurniture requested a review from a team as a code owner November 13, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit orders cannot be used starting from native assets
1 participant