Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only download runner if not already installed #71

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

greg-cook
Copy link
Contributor

This change is aimed at allowing initial support of the Cirrus images
These images come preinstalled with the actions-runner so we can skip to the configuration step.

@greg-cook greg-cook requested a review from simonbs as a code owner March 15, 2024 12:31
Copy link
Contributor

@simonbs simonbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm curious to hear how you plan to support Cirrus' runner images 👀

@NikoRoberts
Copy link

NikoRoberts commented Mar 16, 2024

hi @simonbs 👋
The way we were looking to use the images was essentially use them inside Tartelet as they already show up in the dropdown of Tart VMs.
image
But when we tried to run Tartelet it just kept rebooting the VM because the mkdir command was failing.
The reason we were looking at this option was because were hoping to have a fleet of internal devices to provide additional parallelism, but maintain a few Cirrus runners as the core devices that can run the pipeline if our internal hardware isn't available

It also means all the configuration of the accounts on the VM is already done

@simonbs
Copy link
Contributor

simonbs commented Mar 16, 2024

@NikoRoberts Thanks for providing the details! This sounds like an interesting approach.

@simonbs simonbs merged commit 4e14625 into shapehq:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants