fix(DASH): Exclude text segments when calculating max segment size (#…

…7564) This PR excludes the use of text segments when calculating the max segment size. This is due to Shaka using the max value between the buffer behind and max segment size. The max segment size of text segments can be a lot larger than video segments. This can cause the buffer behind to be extremely large and is a particular problem for low powered devices, which have memory constraints. --------- Co-authored-by: Joey Parrish <[email protected]>
shaka-project · Nov 12, 2024 · d20a870 · d20a870
1 parent 8b0c1eb
commit d20a870
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -45,6 +45,7 @@ Gil Gonen <[email protected]>
 Giorgio Gamberoni <[email protected]>
 Giuseppe Samela <[email protected]>
 Google Inc. <*@google.com>
+Hassan Bashir <[email protected]>
 Ivan Kohut <[email protected]>
 Itay Kinnrot <[email protected]>
 Jaeseok Lee <[email protected]>

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
@@ -63,6 +63,7 @@ Gerardo Meola <[email protected]>
 Gil Gonen <[email protected]>
 Giorgio Gamberoni <[email protected]>
 Giuseppe Samela <[email protected]>
+Hassan Bashir <[email protected]>
 Hichem Taoufik <[email protected]>
 Ivan Kohut <[email protected]>
 Itay Kinnrot <[email protected]>

diff --git a/lib/dash/segment_template.js b/lib/dash/segment_template.js
@@ -85,7 +85,9 @@ shaka.dash.SegmentTemplate = class {
         },
       };
     } else if (info.segmentDuration) {
-      if (!isUpdate && context.adaptationSet.contentType !== 'image') {
+      if (!isUpdate &&
+          context.adaptationSet.contentType !== 'image' &&
+          context.adaptationSet.contentType !== 'text') {
         const periodStart = context.periodInfo.start;
         const periodId = context.period.id;
         const initialPeriodDuration = context.periodInfo.duration;
@@ -172,7 +174,9 @@ shaka.dash.SegmentTemplate = class {
         tsi.evict(availabilityStart);
       }
 
-      if (info.timeline && context.adaptationSet.contentType !== 'image') {
+      if (info.timeline &&
+          context.adaptationSet.contentType !== 'image' &&
+          context.adaptationSet.contentType !== 'text') {
         const timeline = info.timeline;
         context.presentationTimeline.notifyTimeRange(
             timeline,