shader_recompiler: shaer patch to manualy normalize on unsupported Vulkan UNORM/SNORM formats #1532
+136
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: atomic instructions
|
Please verify that the patch is correct. I was not able to test it myself. |
|
In Beach Buggy Racing, it seems this does not work |
|
This pr only covers 32 bit normalized numbers, does the game black screen? |
|
No the game works fine and is playable, other than no way of saving progress due to it storing data online |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan doesn't have support for SNORM/UNORM number formats for 32, 32_32, 32_32_32 and 32_32_32_32 data formats. Insteed use SINT/UINT and normalize/unormalize on shader when reading/writing.
Maybe we don't need to specialize by number of components, I can revert that.