Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable the auto updater #1490

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ngoquang2708
Copy link
Contributor

@ngoquang2708 ngoquang2708 commented Nov 6, 2024

Auto updater should not be enabled for local build.

Cc: @DanielSvoboda

@ngoquang2708 ngoquang2708 marked this pull request as ready for review November 6, 2024 09:48
@ngoquang2708 ngoquang2708 marked this pull request as draft November 6, 2024 09:57
@jardon
Copy link

jardon commented Nov 6, 2024

i guess my question for this is would it be better to be opt-out on updates instead of opt-in?

@ngoquang2708
Copy link
Contributor Author

i guess my question for this is would it be better to be opt-out on updates instead of opt-in?

You mean name the flag ENABLE_UPDATER or DISABLE_UPDATER, right?

@ngoquang2708
Copy link
Contributor Author

ngoquang2708 commented Nov 6, 2024

I don't think anyone want to type more when build locally!
Only AppImages use the auto updater.

@jardon
Copy link

jardon commented Nov 6, 2024

does that not also impact windows and mac users?

@ngoquang2708
Copy link
Contributor Author

does that not also impact windows and mac users?

The auto updater should only functional when files download from this repo. I already enable it in build.yaml.

@jardon
Copy link

jardon commented Nov 6, 2024

i meant more of the "typing while building locally".

but either way is fine with me.

@DanielSvoboda
Copy link
Contributor

in the CMakeLists.txt file on line 34, you should add something like this to be able to select within vscode:

option(ENABLE_UPDATER "Enables the options to updater" ON)

image

@ngoquang2708
Copy link
Contributor Author

@DanielSvoboda Do you think we should set it to OFF by default since the updater won't function correctly in local build? Of-course we can enable it to test.

@DanielSvoboda
Copy link
Contributor

@DanielSvoboda Do you think we should set it to OFF by default since the updater won't function correctly in local build? Of-course we can enable it to test.

It works perfectly, when I compile it on my machine I can update it normally. What problem are you facing?

@ngoquang2708
Copy link
Contributor Author

Think about it this way. You compile it, then install it somewhere. Run it. Update it. You got the version from github not the version you compiled. Of course we dev want to test the update funtionality so se enable it to test.

@DanielSvoboda
Copy link
Contributor

The version that I compile from my machine I usually don't use AutoUpdater, because I update the repository and compile the new version, and I believe that few people use AutoUpdater in the local build. I use AutoUpdater with the version that I downloaded. But I think that this option can be ON, and if someone wants to change it, it is up to the person to change it.

@ngoquang2708
Copy link
Contributor Author

Yeah, that my point. We have to enable explicitly to use it because we know we gonna using it. And I already enable it in the build.yaml for this repo.

@jardon
Copy link

jardon commented Nov 7, 2024

I've actually changed my opinion on the opt-in vs opt-out nature of this.

The auto-updater assumes the build comes directly from GitHub as an app image/pkg/exe. and if shadps4 is distributed in any sort of way outside of builds from GitHub, the update system doesn't really apply or work.

Thats why I think it's actually better to opt in to the updater for the GitHub builds and that's it

@@ -843,8 +849,11 @@ else()
endif()

if (ENABLE_QT_GUI)
target_link_libraries(shadps4 PRIVATE Qt6::Widgets Qt6::Concurrent Qt6::Network Qt6::Multimedia)
add_definitions(-DENABLE_QT_GUI)
target_link_libraries(shadps4 PRIVATE Qt6::Widgets Qt6::Concurrent Qt6::Network Qt6::Multimedia)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nitpicky and probably unintentional, but did you mean to change the spacing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, some place use 2, some place use 4, this place use 3 :(

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only we had a ci/cd system that linted PRs 🙃

@raphaelthegreat raphaelthegreat merged commit a547b27 into shadps4-emu:main Nov 7, 2024
10 checks passed
@ngoquang2708 ngoquang2708 deleted the updater branch November 7, 2024 13:03
fpiesche pushed a commit to fpiesche/shadPS4 that referenced this pull request Nov 7, 2024
fpiesche pushed a commit to fpiesche/shadPS4 that referenced this pull request Nov 7, 2024
fpiesche pushed a commit to fpiesche/shadPS4 that referenced this pull request Nov 7, 2024
fpiesche pushed a commit to fpiesche/shadPS4 that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants