Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IT_SET_QUEUE_REG and IT_SET_PREDICATION PM4 packets #1205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikusp
Copy link
Contributor

@mikusp mikusp commented Oct 2, 2024

No description provided.

@dbz400
Copy link
Contributor

dbz400 commented Oct 3, 2024

Will test out with CUSA00008 - KILLZONE™ SHADOW FALL which hits PM4 type 3 0x20

[Debug] liverpool.cpp:ProcessGraphics:550: Unreachable code!
Unknown PM4 type 3 opcode 0x20 with count 2

@LlysiX
Copy link

LlysiX commented Oct 5, 2024

Tested on rock band 4 (1.08), which previously errored out on SetPredication

Before: Crash on title screen, Unknown PM4 type 3 opcode 0x20 with count 2
After: Works
image

@smiRaphi
Copy link

smiRaphi commented Oct 5, 2024

Tested with CUSA19264 - Yo Kai Watch 4 and it crashes with this error, I don't know if this is caused by this addition or if it's just something after the pm4 type 3 error

[Debug] <Critical> decode.cpp:operator():264: Assertion Failed!
Instruction format table incomplete for opcode  (13, encoding = )

shad_log.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants