-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add analyzer for direct command handler calls #607
base: master
Are you sure you want to change the base?
Conversation
Hi, I'll definitely have a look & merge this in a few days. Want to finish with Rpc first. |
In the current state this should be considered a proof of concept. Unfortunately I don't have the time to properly finish this right now. |
Hi, still didn't get back to this - a lot of stuff on my plate, but I remember about this. |
Hi, I look up the code - couple quick things:
I suspect there might be issues with two later tests. Overall, the attributes are inherited in Fusion - both from base classes and from the interfaces, so doing a totally correct check is kinda complicated. But covering even the primary case would be nice. That's why I wrote "maybe add a test" - i.e. I think it's good to cover at least these scenarios (they are frequent), as for anything beyond that (e.g. inspecting the whole inheritance chain), I think it's fine to do this in some other step, or even ignore this. |
@meenzen please check out my comment above, and sorry for delaying this. |
# Conflicts: # Stl.Fusion.sln
No description provided.