Merge pull request #88 from serlo/fix-dbdump-drop-databse

fix(dbdump): really drop database first, important when renaming tables
serlo · Jun 23, 2024 · 31dc575 · 31dc575
2 parents e93b160 + e458c5a
commit 31dc575
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/envs/production/main.tf b/envs/production/main.tf
@@ -69,7 +69,7 @@ module "gcloud_postgres" {
 
 module "athene2-dbdump" {
   source    = "../../modules/dbdump"
-  image     = "eu.gcr.io/serlo-shared/athene2-dbdump-cronjob:3.4.1"
+  image     = "eu.gcr.io/serlo-shared/athene2-dbdump-cronjob:3.4.2"
   namespace = kubernetes_namespace.api_namespace.metadata.0.name
   node_pool = module.cluster.node_pools.non-preemptible
   schedule  = "0 0 * * *"

diff --git a/images/dbdump/Makefile b/images/dbdump/Makefile
@@ -4,7 +4,7 @@ local_image=serlo/$(image_name)
 # change version if you want to push a new image
 major_version=3
 minor_version=4
-patch_version=1
+patch_version=2
 version=$(major_version).$(minor_version).$(patch_version)
 
 include ../docker.mk

diff --git a/images/dbdump/run.sh b/images/dbdump/run.sh
@@ -19,7 +19,7 @@ set -e
 log_info "dump serlo.org database - start"
 log_info "dump legacy serlo database schema"
 
-mysqldump $mysql_connect --no-data --lock-tables=false --add-drop-database serlo >mysql.sql
+mysqldump $mysql_connect --no-data --lock-tables=false --add-drop-database --databases serlo >mysql.sql
 
 mysqldump $mysql_connect --no-create-info --lock-tables=false --add-locks --ignore-table=serlo.user serlo >>mysql.sql