Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-image): use editor testing secret to upload to testing bucket #3915

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

hejtful
Copy link
Contributor

@hejtful hejtful commented Jul 1, 2024

API PR: serlo/api.serlo.org#1624
CFW PR: serlo/cloudflare-worker#810
Infra PR: serlo/infra#90

A new "serlo-editor-testing" bucket is open for media uploaded while testing integrations of the Editor.

To be able to upload to the new bucket, the Editor needs to receive the secret (as testingSecret general config prop).

The frontend (serlo.org) still uses its old configuration, no changes there.

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jul 1, 2024 8:07am

Copy link
Contributor

github-actions bot commented Jul 1, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 104.31 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@hejtful hejtful marked this pull request as ready for review July 1, 2024 12:48
@hejtful hejtful merged commit 3ef117a into staging Jul 2, 2024
7 checks passed
@hejtful hejtful deleted the feat/plugin-image-serlo-editor-testing-secret branch July 2, 2024 12:39
@elbotho elbotho mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant