fix: Mail.add_header doesn't accept a dict #1054
Closed
+145
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #997
Headers are correctly added even if the argument of add_header is of type dict.
The current spec seems to intend that only the first key/value is added when a dict type argument is given. I couldn't figure out why this implementation.
I think the spec should apply to all keys/values that a dict argument has. The current spec is non-intuitive and confusing to users.
However, changes for supports to multiple key/value pairs could result in "breaking change", so the policy in this pull request was to keep changes to a minimum.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.