chore: Move script compilation from @rollup/stream to plain rollup. #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1618 +/- ##
==========================================
- Coverage 87.37% 87.03% -0.34%
==========================================
Files 44 44
Lines 895 895
Branches 96 96
==========================================
- Hits 782 779 -3
- Misses 103 107 +4
+ Partials 10 9 -1 ☔ View full report in Codecov by Sentry. |
shirblc
force-pushed
the
feature/convert_to_rollup
branch
from
de880b8
to
0c45235
Compare
danted22
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been using rollup/stream for script compilation, but apparently rollup/stream doesn't yet support chunking or multiple entry files (see rollup/stream#13 and rollup/rollup#4137). If we want to enable chunking, we need to use rollup itself.
Issue link
--
Expected behavior
--
Your solution
Switched the script compilation tasks to use rollup instead of the rollup/stream wrapper. Still haven't done the chunking itself, but the initial results are already considerably better.
Additional information
--