Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.4.24 #156

Merged
merged 4 commits into from
Oct 13, 2024
Merged

Rc 1.4.24 #156

merged 4 commits into from
Oct 13, 2024

Conversation

semuadmin
Copy link
Contributor

PyGPSClient Pull Request Template

Description

FIxes.

  1. Fix for GSV issue in graphview and skyview widgets.

Fixes #155

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • GSV processing revalidated

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain test coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the bug Something isn't working label Oct 13, 2024
@semuadmin semuadmin added this to the RC 1.4.24 milestone Oct 13, 2024
@semuadmin semuadmin requested a review from a team October 13, 2024 20:20
@semuadmin semuadmin self-assigned this Oct 13, 2024
@semuadmin semuadmin merged commit 432584e into master Oct 13, 2024
@semuadmin semuadmin deleted the RC-1.4.24 branch October 13, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphview and Skyview widges omitting some NMEA GSV SVIDs
1 participant