Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Buddy CI environment variables in README #391

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

czuli
Copy link

@czuli czuli commented Jul 26, 2024

This PR updates the Buddy CI documentation to reflect the current support for environment variables in Pull Request builds. Buddy now provides the necessary environment variables to determine the source and target branches, enabling accurate detection of branch and prBranch properties by env-ci.

Changes:

  • Updated the supported CI table for Buddy.
  • Revised the explanatory text to reflect the availability of BUDDY_EXECUTION_PULL_REQUEST_HEAD_BRANCH and BUDDY_EXECUTION_PULL_REQUEST_BASE_BRANCH.

References:

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@czuli
Copy link
Author

czuli commented Jul 29, 2024

Revert package-lock.json , update README.md and update buddy.js

@czuli
Copy link
Author

czuli commented Jul 31, 2024

Hi @travi

I've resolved the issues mentioned in the review comments. Can you please take another look and let me know if there's anything else needed to get this PR merged?

Thank you!

@travi
Copy link
Member

travi commented Aug 2, 2024

thanks for the updates @czuli. this is looking good. we'll need to also update the tests that correspond to your code changes. you can reference the existing tests for that file and others to get an idea of how we verify these behaviors. as you can see, the ci workflow currently fails without those updates. could you look into updating those tests as part of this change?

keep in mind that you can run npm test locally to run all of the verification that runs in the ci workflow before pushing changes to the branch here on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants