Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURESIGN-1044] Error handler #443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[SECURESIGN-1044] Error handler #443

wants to merge 2 commits into from

Conversation

bouskaJ
Copy link
Collaborator

@bouskaJ bouskaJ commented Jun 14, 2024

This is my proposal on how to solve https://issues.redhat.com/browse/SECURESIGN-1001 or similar issues.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bouskaJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Jun 14, 2024

/hold

we need to implement similar functionality for CTlog before decreasing CreateTreeDeadline timeout.

@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Jun 14, 2024

@JasonPowr @tommyd450 @osmman WDYT?

@bouskaJ bouskaJ force-pushed the SECURESIGN-1044 branch 2 times, most recently from 2c2485a to f297055 Compare June 20, 2024 10:36
@bouskaJ bouskaJ force-pushed the SECURESIGN-1044 branch 2 times, most recently from 9007bc4 to 67a119a Compare June 21, 2024 12:04
@bouskaJ bouskaJ marked this pull request as draft June 24, 2024 08:51
@bouskaJ bouskaJ force-pushed the SECURESIGN-1044 branch 3 times, most recently from c6e2cd7 to 370598c Compare July 1, 2024 10:38
@bouskaJ bouskaJ requested a review from osmman July 1, 2024 11:25
@bouskaJ bouskaJ marked this pull request as ready for review July 1, 2024 11:25
@openshift-ci openshift-ci bot requested review from cooktheryan and lance July 1, 2024 11:25
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Jul 2, 2024

/unhold

@bouskaJ bouskaJ force-pushed the SECURESIGN-1044 branch 6 times, most recently from 08fc000 to 5ed84a6 Compare July 25, 2024 08:46
@bouskaJ bouskaJ requested a review from osmman July 29, 2024 04:49
@bouskaJ bouskaJ requested a review from osmman July 30, 2024 04:36
@osmman
Copy link
Contributor

osmman commented Jul 30, 2024

/hold

@osmman osmman added this to the 1.2.0 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@lance lance Awaiting requested review from lance

@tommyd450 tommyd450 Awaiting requested review from tommyd450

@osmman osmman Awaiting requested review from osmman

Assignees

@osmman osmman

Labels
approved do-not-merge/hold
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bouskaJ @osmman @openshift-merge-robot