-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gas-oracle): support gas token volatile exchange rate #1526
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1526 +/- ##
===========================================
- Coverage 52.01% 51.73% -0.29%
===========================================
Files 156 157 +1
Lines 12974 13050 +76
===========================================
+ Hits 6749 6751 +2
- Misses 5641 5713 +72
- Partials 584 586 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Co-authored-by: colin <[email protected]>
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
Since we support using alternative gas on L2, we should include l2_gas_token/l1_gas_token price information in to gas price both ways. So here we support retrieve l2_gas_token/l1_gas_token price from binance_api, and includeit in the fee data if alternative gas token enabled.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?