Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gas-oracle): support gas token volatile exchange rate #1526

Merged
merged 26 commits into from
Oct 14, 2024

Conversation

yiweichi
Copy link
Member

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

Since we support using alternative gas on L2, we should include l2_gas_token/l1_gas_token price information in to gas price both ways. So here we support retrieve l2_gas_token/l1_gas_token price from binance_api, and includeit in the fee data if alternative gas token enabled.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@yiweichi yiweichi added the bump-version Bump the version tag for deployment label Sep 30, 2024
@yiweichi yiweichi changed the title Feat gas oracle exchange rate feat: gas oracle exchange rate Sep 30, 2024
@yiweichi yiweichi changed the title feat: gas oracle exchange rate feat(gas-oracle): support gas token volatile exchange rate Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 2.63158% with 74 lines in your changes missing coverage. Please review.

Project coverage is 51.73%. Comparing base (e3c87e6) to head (98dcb74).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
rollup/internal/utils/exchange_rate.go 0.00% 32 Missing ⚠️
rollup/internal/controller/relayer/l1_relayer.go 0.00% 20 Missing and 1 partial ⚠️
rollup/internal/controller/relayer/l2_relayer.go 8.69% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1526      +/-   ##
===========================================
- Coverage    52.01%   51.73%   -0.29%     
===========================================
  Files          156      157       +1     
  Lines        12974    13050      +76     
===========================================
+ Hits          6749     6751       +2     
- Misses        5641     5713      +72     
- Partials       584      586       +2     
Flag Coverage Δ
rollup 55.33% <2.63%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yiweichi yiweichi requested review from Thegaram and colinlyguo and removed request for Thegaram October 8, 2024 13:42
NazariiDenha
NazariiDenha previously approved these changes Oct 9, 2024
rollup/internal/config/relayer.go Show resolved Hide resolved
colinlyguo
colinlyguo previously approved these changes Oct 9, 2024
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

colinlyguo
colinlyguo previously approved these changes Oct 9, 2024
colinlyguo
colinlyguo previously approved these changes Oct 14, 2024
rollup/internal/utils/exchange_rate.go Show resolved Hide resolved
@yiweichi yiweichi merged commit f2a656d into develop Oct 14, 2024
@yiweichi yiweichi deleted the feat-gas-oracle-exchange-rate branch October 14, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants