Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): use params map to initialize provers #1507

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

amoylan2
Copy link
Member

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

roynalnaruto
roynalnaruto previously approved these changes Aug 27, 2024
Copy link
Contributor

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

lispc
lispc previously approved these changes Aug 27, 2024
Copy link
Contributor

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for prover. But for testing codes, can it load ZKEVM_DEGREES and AGG_DEGREES both?

@amoylan2
Copy link
Member Author

OK for prover. But for testing codes, can it load ZKEVM_DEGREES and AGG_DEGREES both?

We can merge this first, adding another patch to mitigate the test issues.

@amoylan2 amoylan2 added the bump-version Bump the version tag for deployment label Aug 27, 2024
@github-actions github-actions bot dismissed stale reviews from lispc and roynalnaruto via 8671048 August 27, 2024 10:54
@georgehao georgehao merged commit 865d65a into develop Aug 27, 2024
6 checks passed
@georgehao georgehao deleted the fix/coordinator-init-lifetime2 branch August 27, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants