[experiment] Remove PROGRAM_SIZE from type #587
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naure
reviewed
Nov 15, 2024
ceno_zkvm/src/structs.rs
Outdated
| @@ -152,10 +152,10 @@ impl<E: ExtensionField> ZKVMConstraintSystem<E> { | |||
| config | |||
| } | |||
|
|
|||
| pub fn register_table_circuit<TC: TableCircuit<E>>(&mut self) -> TC::TableConfig { | |||
| pub fn register_table_circuit<TC: TableCircuit<E>>(&mut self, tc: TC) -> TC::TableConfig { | |||
There was a problem hiding this comment.
There could be a convenience method (original name) that uses Default (if implemented) and a new one with the parameter.
impl<TC> …
where TC::TableConfig: Default {
pub fn register_table_circuit(…) {
let tc = Default::default();
…
}
impl<TC> … {
pub fn register_table_circuit_param(…, tc: TC) {
…
}There was a problem hiding this comment.
This way there is no need to change every call.
There was a problem hiding this comment.
👍 agreed, got a bit carried away there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naure: