[APT-10467] Retry with Exponential Backoff #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschults
reviewed
Sep 20, 2024
| if (loadErrorInfo.errorCount > 8) { | ||
| C.TIME_UNSET //stop retrying after a few minutes | ||
| } else { | ||
| //exponential backoff based on a 10 second interval |
There was a problem hiding this comment.
Can you put in what the max backoff will be? My reading is that will be up to 40 minutes, but it should be written down.
| C.TIME_UNSET //stop retrying after a few minutes | ||
| } else { | ||
| //exponential backoff based on a 10 second interval | ||
| (1 shl (loadErrorInfo.errorCount - 1).coerceAtMost(8)) * 10 * 1000L |
There was a problem hiding this comment.
I don't think you need the coerce here - error count will never be more than 8.
Adds graceful network retries to internet connectivity errors. And attempts to retry `ParserException`, in the event that the download partially failed for content being loaded over the internet.
kabliz
force-pushed
the
kabliz/APT-10467-retry
branch
from
debf27a
to
bfa6087
Compare
kschults
approved these changes
Sep 23, 2024
griffinfscribd
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds graceful network retries to internet connectivity errors.
And attempts to retry
ParserException, in the event that the download partially failed for content being loaded over the internet.