Skip to content

Commit

Permalink
Revert "Test browser crash only in Linux"
Browse files Browse the repository at this point in the history
This reverts commit a1d12b0.
  • Loading branch information
elacuesta committed Jul 23, 2024
1 parent a1d12b0 commit 5939d6f
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions tests/tests_asyncio/test_browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,10 @@ async def test_browser_closed_restart(self):
== 2 # one at the beginning, one after calling Browser.close() manually
)

@pytest.mark.skipif(platform.system() != "Linux")
@pytest.mark.skipif(
platform.system() == "Windows",
reason="os.kill does not work as expected on Windows",
)
async def test_browser_crashed_restart(self):
spider = Spider("foo")
async with make_handler(settings_dict={"PLAYWRIGHT_BROWSER_TYPE": "chromium"}) as handler:
Expand Down Expand Up @@ -231,7 +234,10 @@ async def test_browser_crashed_restart(self):
== 2 # one at the beginning, one after killing the broser process
)

@pytest.mark.skipif(platform.system() != "Linux")
@pytest.mark.skipif(
platform.system() == "Windows",
reason="os.kill does not work as expected on Windows",
)
async def test_browser_crashed_do_not_restart(self):
spider = Spider("foo")
settings_dict = {
Expand Down

0 comments on commit 5939d6f

Please sign in to comment.