POC: add Unset and UnsetType #116
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 99.56% 99.24% -0.32%
==========================================
Files 25 25
Lines 921 929 +8
==========================================
+ Hits 917 922 +5
- Misses 4 7 +3
|
Gallaecio
reviewed
Jan 25, 2023
|
|
||
| # Represents a field that hasn't been set with any values instead of being | ||
| # None. | ||
| Unset = UnsetType() |
There was a problem hiding this comment.
I wonder if it should be capitalized as UNSET.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC for now.
Used in zytedata/zyte-common-items#21.