Changed the lupa imports un jupyter kernel #996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First thank you very much for providing such a great tool, it is awesome and I have used it in the past and come back to using it.
I propose that tiny change if you find it useful. With it, it becomes possible to require lua libraries using binary (*.so) files. The issue is that "CPython needs to enable global symbol visibility for shared libraries before loading the Lupa module" to quote directly the lupa PyPI page. So I just changed the visibility before loading lupa and changed it back afterwards for the jupyter notebook kernel. Without the change, while trying to require socket, python would not use the lua binaries and so it would ask for unknown functions such as lua_gettop.
My use of that change is that I want to automate things while using a Tor container, so I need to be able to create sockets which will tell Tor to create a new identity when the identity i have is not correct.
I asked for master because I didn't find any dev branch
I tried to run a splash notebook with my version of the code and I can now require socket and this simple code ran perfectly fine
I ran the tests and got that, and as I don't know your project well enough to know if my change is the cause of those regressions, It would be great if you could give me some directions on that.