Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cut old python versions from ci #200

Merged
merged 2 commits into from
Oct 8, 2022
Merged

cut old python versions from ci #200

merged 2 commits into from
Oct 8, 2022

Conversation

sbdchd
Copy link
Contributor

@sbdchd sbdchd commented Oct 6, 2022

In preparation for adding type hints, this PR removes python 2.7 and 3.5 from the CI matrix.

Removing 2.7 means we can use the builtin types instead of type comments.

rel: #199

lopuhin
lopuhin reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sbdchd thanks for the PR, could you please also update tox.ini and setup.py?

@sbdchd sbdchd requested a review from lopuhin October 8, 2022 02:50
lopuhin
lopuhin approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@lopuhin lopuhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @sbdchd 👍

@lopuhin lopuhin merged commit d7b3f41 into scrapinghub:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopuhin lopuhin lopuhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbdchd @lopuhin