-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update statement creation to rev a4645e4bc3e78ad5cfd9f8347c7e0ac8267c1079 of SCITT arch and implement verification of statements #39
Conversation
81ae47c
to
e2406fe
Compare
I realized that |
I updated some of our examples but it's possible there are leftovers I missed elsewhere |
I'm new enough @pdxjohnny that I need to reread the CBOR and work with the group on this one. |
7427c9b
to
8a57b03
Compare
$ git ls-files '*.py' | xargs autoflake --in-place --remove-all-unused-imports --ignore-init-module-imports Signed-off-by: John Andersen <[email protected]>
Asciinema: https://asciinema.org/a/627130 Signed-off-by: John Andersen <[email protected]>
Signed-off-by: John Andersen <[email protected]>
Tests passing as of https://asciinema.org/a/627194 Asciinema: https://asciinema.org/a/627150 Asciinema: https://asciinema.org/a/627165 Asciinema: https://asciinema.org/a/627183 Asciinema: https://asciinema.org/a/627193 Asciinema: https://asciinema.org/a/627194 Signed-off-by: John Andersen <[email protected]>
Asciinema: https://asciinema.org/a/627198 Signed-off-by: John Andersen <[email protected]>
Signed-off-by: John Andersen <[email protected]>
Signed-off-by: John Andersen <[email protected]>
…lic key resolvers tested seperatly Signed-off-by: John Andersen <[email protected]>
Signed-off-by: John Andersen <[email protected]>
This PR will be merged unless there are objections in 2 weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pdxjohnny
LGTM
Thanks guys! |
… statements (via receipts list) Signed-off-by: John Andersen <[email protected]>
Helpful for OIDC audience Signed-off-by: John Andersen <[email protected]>
@OR13 @SteveLasker I pushed a couple minor commits over top since hopefully today's the day, I'm in progress on a relying party OIDC issuer based off transparent statement for BOM to make workload identities for AI agents and those last two make it a little cleaner, hope that's alright. Thank you again for the reviews! Related: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you guys! |
Related: scitt-community#39 Signed-off-by: John Andersen <[email protected]>
Related: scitt-community#39 Signed-off-by: John Andersen <[email protected]>
There were a couple issues in the CI jobs which trigger on |
* ci: notarize: Add --subject to statement creation Related: #39 Signed-off-by: John Andersen <[email protected]> * ci: notarize: on: pull request: Test against main PRs Related: #39 Signed-off-by: John Andersen <[email protected]> * Revert "ci: notarize: on: pull request: Test against main PRs" Run actions/github-script@v6 Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable at Function.<anonymous> (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:585:23) at Generator.next (<anonymous>) at /home/runner/work/_actions/actions/github-script/v6/dist/index.js:522:71 at new Promise (<anonymous>) at __webpack_modules__.8041.__awaiter (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:518:12) at Function.getIDToken (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:571:16) at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:421:46) at Generator.next (<anonymous>) at /home/runner/work/_actions/actions/github-script/v6/dist/index.js:133:71 at new Promise (<anonymous>) Error: Unhandled error: Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable This reverts commit d4ea9ea. --------- Signed-off-by: John Andersen <[email protected]>
Related: ietf-wg-scitt/draft-ietf-scitt-architecture@a4645e4
Ping @OR13, @aj-stein-nist, @fournet. Does this look correct for the notary?
did:jwk
issuersdid:web
issuersdid:web