-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primal-dual evolution event handler recipe #916
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
==========================================
+ Coverage 52.29% 53.99% +1.70%
==========================================
Files 20 21 +1
Lines 3991 4380 +389
==========================================
+ Hits 2087 2365 +278
- Misses 1904 2015 +111 ☔ View full report in Codecov by Sentry. |
you can capture the final state using the
I think in recipes is ok but without the plotting and with good documentation :) and thanks a lot João! |
Co-authored-by: Mohammed Ghannam <[email protected]>
Co-authored-by: Mohammed Ghannam <[email protected]>
Thanks for the suggestions, Mo! I ended up copying the gas transportation model for the plotting example because importing stuff with python from different folders is somewhat finicky. I could have added a couple of lines using sys, but I feel like it would potentially complicate things for inexperienced users. Also Mo and @Opt-Mucca, what do you think of creating an issue asking users to give us some of their pyscipopt models so that we can expand on the utils? |
@Joao-Dionisio I strongly support asking users to contribute models! That would be super helpful for our testing. For this MR: I like the recipe and the example's fine (even if it does have a lot of duplicate code). My issue is with the changes in the tests, and I'm a bit curios from the design POV. |
Based on #881, I think it's helpful to include the answer as a recipe.
It's a bit scuffed, I think one needs to capture the final state of the problem, as the event handler is not called when the solving stops.
I'm also unsure about the best way to separate things, I decided just to include the event handler in the recipe and the user would need to optimize the model themselves, as well as plot the solutions afterward. I'd be happy with better suggestions, though.