Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github_app.md #381

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Update github_app.md #381

merged 1 commit into from
Sep 24, 2024

Conversation

mroderick
Copy link
Contributor

actions/checkout is now at v4

At the time of making this PR at 4.1.7.

See https://github.com/actions/checkout/releases/

actions/checkout is now at v4
Copy link

netlify bot commented Sep 24, 2024

👷 Deploy request for squawkhq pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e6ba528

Copy link
Collaborator

@chdsbd chdsbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@chdsbd chdsbd added the automerge automerge with kodiak label Sep 24, 2024
@kodiakhq kodiakhq bot merged commit 0ced957 into sbdchd:master Sep 24, 2024
19 checks passed
@mroderick
Copy link
Contributor Author

I posted it too soon! The example doesn't work with actions/checkout@v4 ... I'm looking into it, but it might take a day or two

@mroderick mroderick deleted the patch-1 branch September 24, 2024 15:24
mroderick added a commit to mroderick/squawk that referenced this pull request Sep 24, 2024
Fix mistake added in sbdchd#381, where updating to `actions/checkout` past `v1` would mean the example stops working.

This is due to change in the checkout functionality in `actions/checkout` introduced in v2 (beta). See https://github.com/actions/checkout/blob/main/CHANGELOG.md#v2-beta
@mroderick mroderick mentioned this pull request Sep 24, 2024
kodiakhq bot pushed a commit that referenced this pull request Sep 24, 2024
Fix mistake added in #381, where updating to `actions/checkout` past `v1` would mean the example stops working.

This is due to change in the checkout functionality in `actions/checkout` introduced in v2 (beta). See https://github.com/actions/checkout/blob/main/CHANGELOG.md#v2-beta
@mroderick
Copy link
Contributor Author

I fixed the broken example in #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge with kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants