Add selector for memo type and fix stellar-expert fetch #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<MemoSelector>component<MemoInput>component which acts similar as the<PriceInput>component. It's basically a TextField that has a memo-selector as a start adornment<MemoInput>field in the payment formInstead of fetching all known-accounts in batches and storing them in the cache, I replaced
fetchWellKnownAccounts()withfetchWellKnownAccount()which fetches an individual account address from stellar-expert and stores the result in the cache.Since the
lookup()function call may include a fetch it now returns a promise.The stellar-expert directory API does not differentiate between testnet and pubnet anymore. That's why the cache-key is now called
"all"instead of"testnet"or"pubnet".Closes #1210.