-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate 🎁🎅 #308
Draft
dotnetCarpenter
wants to merge
12
commits into
sanctuary-js:main
Choose a base branch
from
dotnetCarpenter:feature/validate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
validate 🎁🎅 #308
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6e5027f
initial validation of custom data type
dotnetCarpenter 485e653
handle multiple properties and emit multiple Lefts/Rights
dotnetCarpenter 482147b
omit multiple Rights, guard for null value and did more tests
dotnetCarpenter 8a58fc6
add proper tests for validate
dotnetCarpenter 202cd79
added tests for types with propPath
dotnetCarpenter fedebe0
fixed validate description
dotnetCarpenter 1234bb4
fixed typo in validate description
dotnetCarpenter 6d4f677
fixed validate signature
dotnetCarpenter d404784
Fixed undefined/null value must report MissingValue for properties
dotnetCarpenter a65ebf5
Changed the return type of validate to Either (Array ValidationError) a
dotnetCarpenter 0a30b00
fixed no-lonely-if lint rule
dotnetCarpenter f1ad601
cleanup - drop a few intermittent values
dotnetCarpenter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidchambers this part I'm really not sure about. The idea is to get the name of the Type that is invalid for nested types. I haven't seen any
propPath
that didn't exactly contain['$1']
but I'm sure that there are cases.