Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lint issues. Enable lint checks #30

Merged
merged 2 commits into from
May 10, 2024
Merged

fix lint issues. Enable lint checks #30

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4075dce
fix lint issues. Enable lint checks
vswamidass-sfdc May 7, 2024
d22d6dc
disable runner
vswamidass-sfdc May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/rubyonrails.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,5 @@ jobs:
run: bundle exec bundler-audit --update
- name: Security audit application code
run: bundle exec brakeman -q -w2
#- name: Lint Ruby files
# run: bundle exec rubocop --parallel
- name: Lint Ruby files
run: bundle exec rubocop --parallel
9 changes: 8 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ AllCops:
- 'db/schema.rb'
- 'bin/*'
- 'node_modules/**/*'
- 'app/jobs/generate_answer_job.rb' # Exclude until we can refactor
- 'app/controllers/concerns/salesforce_gpt_concern.rb'
- 'app/controllers/concerns/gpt_concern.rb'

Style/StringLiterals:
EnforcedStyle: single_quotes
Expand All @@ -22,7 +25,11 @@ Metrics/MethodLength:
Max: 50

Metrics/AbcSize:
Max: 30
Max: 40

Layout/LineLength:
Max: 200

Lint/MissingSuper:
Exclude:
- 'app/policies/*.rb'
138 changes: 0 additions & 138 deletions app/controllers/concerns/salesforce_gpt_concern.rb
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file isn't needed anymore. It was replaced by gpt_concern.rb

This file was deleted.

2 changes: 1 addition & 1 deletion app/jobs/embed_document_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

class EmbedDocumentJob < ApplicationJob
include SalesforceGptConcern # Include the concern here
include GptConcern # Include the concern here

queue_as :default

Expand Down
Loading