New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@W-17070457 Allow multi conditional !import.meta.env.SSR statements #171

Open

a-chabot wants to merge 3 commits into salesforce:master from a-chabot:a-chabot/multiconditions

a-chabot commented Nov 13, 2024 •

edited

Loading

@W-17070457 Allow multi conditional !import.meta.env.SSR statements

@lwc/lwc/ssr/no-unsupported-properties did not recognize when there is a multi conditional check with !import.meta.env.SSR.

Example: These is the scenario we are trying to fix:

if (!import.meta.env.SSR && randomOtherCheck) {
  this.dispatchEvent(someEvent);
} 

if (randomOtherCheck && !import.meta.env.SSR) {
  this.dispatchEvent(someEvent);
} 

if (!a && b && !c && d && !import.meta.env.SSR) {
  this.dispatchEvent(someEvent);
} 

let hello = (!import.meta.env.SSR && a) ? yes : no

if (!import.meta.env.SSR) {
  this.dispatchEvent(someEvent);
}

a-chabot added 3 commits

November 13, 2024 17:16


          checkConditionalStatement

cda4062


          test attempt 1

894a09d


          formatter

ed5fd4b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet