[droidcamsrc] call droid_media_camera_take_picture from another thread #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peat-psuwit
force-pushed
the
async-take-picture
branch
from
c027f2b
to
c65351b
Compare
peat-psuwit
force-pushed
the
async-take-picture
branch
from
c65351b
to
032ba0d
Compare
peat-psuwit
force-pushed
the
async-take-picture
branch
from
032ba0d
to
42dd102
Compare
|
I've rebased the commit and add additional commit message. @abranson? |
peat-psuwit
force-pushed
the
async-take-picture
branch
from
42dd102
to
c637485
Compare
take_picture call in HAL sometimes need to read information from preview frames for e.g. auto exposure when using flash. If the calling thread also handles pulling preview frames, this will create a deadlock. To prevent this, I've moved the actual droid_media_camera_take_picture() call to a function that will be called in a background thread. The GstTaskPool is used to execute the function in the glib's thread pool, so that the new thread doesn't have to be created every time. This fixed taking a picture with the flash on on Fairphone 2 with Halium 7.1-based port and Ubuntu Touch.
peat-psuwit
force-pushed
the
async-take-picture
branch
from
c637485
to
a0905ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take_picture call in HAL sometimes need to read information from preview
frames for e.g. auto exposure when using flash. If the calling thread
also handles pulling preview frames, this will create a deadlock.
To prevent this, I've moved the actual droid_media_camera_take_picture()
call to a function that will be called in a background thread. The
GstTaskPool is used to execute the function in the glib's thread pool,
so that the new thread doesn't have to be created every time.
This fixed taking a picture with the flash on on Fairphone 2 with
Halium 7.1-based port and Ubuntu Touch.