Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop extremely dated benchmark page #473

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

saraedum
Copy link
Member

it would be nice to show benchmarks but until we have something pretty to show here, we should not show off a Sage from 2009.

it would be nice to show benchmarks but until we have something pretty
to show here, we should not show off a Sage from 2009.
@saraedum
Copy link
Member Author

I did a make and make open locally and everything looked reasonable.

@saraedum
Copy link
Member Author

@GiacomoPope, I cannot assign you as a reviewer here. I guess you do not have the right access to this repo. But please have a look anyway :)

@haraldschilly
Copy link
Member

Is something like that in the documentation? Maybe it's worth linking to it.

Copy link
Member

@haraldschilly haraldschilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to update the benchmarks instead of deleting it, but whatever 🤷‍♂️

@haraldschilly haraldschilly merged commit 3e86cf5 into sagemath:master Jul 19, 2024
1 check passed
@saraedum
Copy link
Member Author

@haraldschilly there are a few similarly dated things in the documentation but they don't tell a story. I am working on updating these and I'll create a PR here once there is something reasonable to show :)

Thanks for merging!

@haraldschilly
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants