This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
manual check for overflow #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkollar
reviewed
Mar 6, 2024
| // prevents overflow | ||
| if baseFee.BitLen() > 256 { | ||
| var maxInt math.Int | ||
| maxValue := new(big.Int).Sub(new(big.Int).Exp(big.NewInt(2), big.NewInt(256), nil), big.NewInt(1)) |
There was a problem hiding this comment.
- Couldn't this computation be done only once and use that value here? Possibly make a copy to avoid changing it elsewhere.
- 256 should probably be math.MaxBitLen instead.
|
The sagaos branch isn't used, it's probably some unfinished experiment with a newer cosmos-sdk. This needs to go against a branch based on 0.22.0 ethermint release. Also there should be a task to also do it for the crypto.org fork, i.e. the 0.7 release and the main branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.