Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with multiple invites being send out with a comma in the recipient name/address #1542

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wlamers
Copy link

@wlamers wlamers commented Feb 7, 2024

When using for example Thunderbird to create an invite an adding Attendees that have a comma in their name in the addressbook (of from collected emailaddresses in received emails) like e.g.:

"test, test [email protected]"

multiple RCPT TO: commands are send over SMTP, potentially causing issues with the mail server (postfix/dovecot). In our case the mail server want to send the invite to both the user "test" as the email "[email protected]". User "test" does not exist, causing the invite to end up in the 'catch-all' email account.

By extracting the emailadress using a regular expression the issue is resolved.

…en there is a ',' in the recipient name/emailaddress'
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we require some unit tests on this change. please add - thx

@phil-davis
Copy link
Contributor

@wlamers are you able to add unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants