More CalDAV empty-array time-range changes #1364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
=========================================
Coverage 97.07% 97.07%
Complexity 2821 2821
=========================================
Files 175 175
Lines 7702 7702
=========================================
Hits 7477 7477
Misses 225 225
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@DeepDiver1975 do you have knowledge/opinion about this? |
phil-davis
force-pushed
the
more-caldav-time-range
branch
from
89bb850
to
3c5283b
Compare
phil-davis
force-pushed
the
more-caldav-time-range
branch
from
3c5283b
to
dd19543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #1300 which specifically sets CalDAV/PropFilter time-range to default to the empty array.
There are other places where
time-rangeis set to false or null by default in various places.Should these all be an empty array?