Skip to content

Commit

Permalink
Merge pull request #125 from rvm/bump_ansible_version_2_2
Browse files Browse the repository at this point in the history 
Bump ansible version from 2.0 to 2.2
  • Loading branch information
@pkuczynski
pkuczynski authored Nov 29, 2016
2 parents 764ad20 + 7adc31a commit 308eda8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ before_install:
- '__rvm_unload ; rm -rf ~/.rvm'

install:
- 'pip install ansible==2.0.0'
- 'pip install ansible==2.2.0'
- 'printf "[defaults]\nroles_path = ../" > ansible.cfg'

script:
Expand Down
2 changes: 1 addition & 1 deletion meta/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ galaxy_info:
description: The official rvm role to install and manage your ruby versions.
company:
license: license (MIT)
min_ansible_version: 1.5
min_ansible_version: 2.2

platforms:
- name: EL
Expand Down
2 changes: 1 addition & 1 deletion tasks/rubies.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
with_items: '{{ rvm1_rubies }}'
changed_when: False
register: ruby_patch
always_run: yes # Run even when in --check mode (http://docs.ansible.com/ansible/playbooks_checkmode.html)
check_mode: no # Run in normal mode when in --check mode (http://docs.ansible.com/ansible/playbooks_checkmode.html)

- name: Install bundler if not installed
shell: >
Expand Down

3 comments on commit 308eda8

@davbre
Copy link

@davbre davbre commented on 308eda8 Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following error when I run this role:

ERROR! 'check_mode' is not a valid attribute for a Task

It works fine as soon as I comment out the line with check_mode: no.

I'm running Ansible 2.1.1.0, and used the following playbook:

---
- name: Configure servers with ruby support for single user
  hosts: all

  roles:
    - { role: rvm_io.ruby,
        tags: ruby,
        rvm1_rubies: ['ruby-2.3.0'],
        rvm1_user: 'david'
      }

@pkuczynski
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davbre it happens because we require Ansible 2.2. Can you upgrade your installation?

@davbre
Copy link

@davbre davbre commented on 308eda8 Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkuczynski - I didn't spot how min_ansible_version: 2.2 is specified. I'll update when I can. Thanks for clarifying.

Please sign in to comment.