Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various codebase rots (stale CI, new Rust lints, broken MSRV checks by transitive dependency upgrades) #164

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Jul 29, 2024

  1. game_activity/ffi: Drop cfg for inexistant target_arch = "armv7"

    [Rust 1.80 from July 25th 2024] points out that `armv7` is not a known,
    valid value for the `target_arch` cfg variable.  This is confirmed by
    the docs not listing it either:
    https://doc.rust-lang.org/reference/conditional-compilation.html#target_arch
    
    Hence drop this entirely, and rely purely on `target_arch = "arm"`.
    
    [Rust 1.80 from July 25th 2024]: https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html
    MarijnS95 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    872d0f7 View commit details
    Browse the repository at this point in the history
  2. Fix unexpected-cfgs by adding api-level-30 feature and removing `…

    …test`
    
    Some code copied from the NDK carried over the respective `feature`
    `cfg` guards, without ever adding the feature to the `[features]` list
    in `Cargo.toml`.  Now that Rust detects these mishaps, we can fix it
    by removing `test` (bindings don't seem to be run-tested) and reexpose
    `ConfigurationRef::screen_round()` which was behind a previously
    unsettable `feature = "api-level-30"`.
    
    Also remove `unsafe impl Send/Sync for ConfigurationRef` since the
    upstream `ndk` already declares `Configuration` to be `Send` and `Sync`,
    and `RwLock` and `Arc` carry that through.
    MarijnS95 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2ac3a7b View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. native_activity: Fix clippy lints around NativeActivityGlue not `Se…

    …ndSync` and unwritten `redraw_needed` field
    MarijnS95 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f8a156f View commit details
    Browse the repository at this point in the history
  2. CI: Remove deprecated/unmaintained actions-rs toolchain setup

    The `actions-rs` containers haven't been maintained and updated for
    years and don't need to: GitHub's actions environment already comes
    fully loaded with a complete `stable` Rust installation with the
    standard tools (in this case `rustfmt`).  Remove the remaining toolchain
    setup (which was already replaced with `hecrj/setup-rust-action`
    elsewhere) to get rid of ancient Node 12 deprecation warnings.
    MarijnS95 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a5194c9 View commit details
    Browse the repository at this point in the history
  3. Bump dependency patch-versions to fix -Zminimal-versions and MSRV c…

    …heck
    
    Use `-Zminimal-versions` in our MSRV check.  This not only ensures
    our minimum version bounds are actually solid and tested (even if
    they may be a bit conservative at times, i.e. we could allow older
    versions except for the crates that are bumped in this patch which were
    explicitly build-tested), it also allows us to use this as a base for
    the MSRV test, and preempt us from failing it whenever a (transitive!)
    dependency bumps its MSRV beyond ours in a *semver-compatible* release.
    MarijnS95 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7a4554c View commit details
    Browse the repository at this point in the history