Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework GNU -m flags #1269

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Rework GNU -m flags #1269

wants to merge 6 commits into from

Commits on Nov 4, 2024

  1. generator: Parse rustc --print cfg

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7414fde View commit details
    Browse the repository at this point in the history

  2. Fall back to rustc's default value for crt-static/static_flag 

    We do this by storing the default target features in `TargetInfo`.
    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    54c1a4c View commit details
    Browse the repository at this point in the history

  3. Avoid -m32/-mx32/-m64 flags on Clang 

    They should be redundant, the `--target` parameter contains the
information already.
    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4047add View commit details
    Browse the repository at this point in the history

  4. Refactor GNU flag determination into TargetInfo::gnu_arch_flags 

    And prepare for adding more architecture-specific flags.

There are no functional changes here (apart from the `-m32`/`-m64` flags
appearing slightly later in the command line, but that shouldn't have
any effect).
    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5c9e9a3 View commit details
    Browse the repository at this point in the history

  5. Add relevant -m32/-m64 on PowerPC and SPARC

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2521e95 View commit details
    Browse the repository at this point in the history

  6. Consistently pass -mfloat-abi=... to GCC 

    It is unsound to call between code built with different floating point
modes, so let's make sure we pass this flag correctly.
    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4cbb0c9 View commit details
    Browse the repository at this point in the history