-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for kvstore, docstore, indexstore in Opensearch #16813
base: main
Are you sure you want to change the base?
Add support for kvstore, docstore, indexstore in Opensearch #16813
Conversation
@logan-markewich I have added integrations for kvstore, docstore, and indexstore. However docstore and indexstore have dependency on kvstore. Is there any process I have to do? The reason I'm thinking this way is because the unit tests are failing. |
@freedom07 That is not why tests are failing. If you read the logs, I see an error llama-index-integrations/storage/kvstore/llama-index-storage-kvstore-opensearch/llama_index/storage/kvstore/opensearch/base.py:29: in <module>
) -> opensearchpy.AsyncOpenSearch:
E AttributeError: module 'opensearchpy' has no attribute 'AsyncOpenSearch' |
@logan-markewich Thank you I understand. But I added opensearch-py package in pyproject.toml. I expected opensearchpy.AsyncOpenSearch to be accessible, but it's not. After installing the poetry toml file within the integration directory and running pytest locally, there were no issues. Do you have any idea what might be causing this? |
@freedom07 Pushed a fix -- looks like it was missing the async extras |
@logan-markewich oh I see. Thank you so much! |
@freedom07 any chance we can add unit tests for the kvstore? Ideally we can mock the clients |
@logan-markewich That sounds like a good idea. However, it's too late today, so I'll give it a try after getting some sleep. |
Description
I added support for kvstore, docstore, indexstore for Opensearch. It makes to do bm25 search and hybrid search.
Fixes #16748
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lint
to appease the lint gods